This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Oculus Quest OpenVR support #214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enabled warnings as errors
# Conflicts: # XRTK-Core/Packages/com.xrtk.core/Extensions/TransformExtensions.cs
# Conflicts: # Submodules/SDK # XRTK-Core/Packages/com.xrtk.core/Inspectors/Data/EditorWindowOptions.json
| @@ -0,0 +1,33 @@ | |||
| // Copyright (c) Microsoft Corporation. All rights reserved. | |||
There was a problem hiding this comment.
Are these copied from the mrtk?
| @@ -0,0 +1,33 @@ | |||
| // Copyright (c) Microsoft Corporation. All rights reserved. | |||
There was a problem hiding this comment.
Are these copied from the mrtk?
| @@ -150,6 +150,7 @@ protected void UpdateSingleAxisData(MixedRealityInteractionMapping interactionMa | |||
| // If our value was updated, raise it. | |||
| if (interactionMapping.Updated) | |||
| { | |||
| Debug.LogError($"Interaction updated {interactionMapping.Description} - Value [{interactionMapping.FloatData}]"); | |||
There was a problem hiding this comment.
Why are these errors here?
Just to verify you're getting data?
|
Pointer issue resolved in the latest SDK PR, turns out to be a mapping issue in the profile |
|
Closing as #234 now implements this more effectively |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview
Adding Oculus Quest OpenVR support
Target of the change:
Is this enhancement for:
Changes:
Brief list of the targeted features that are being changed.